Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing guess_time_type error #371

Merged
merged 4 commits into from
Aug 13, 2024
Merged

fixing guess_time_type error #371

merged 4 commits into from
Aug 13, 2024

Conversation

rnayebi21
Copy link
Contributor

@rnayebi21 rnayebi21 commented Aug 13, 2024

Checklist

Please:

  • Make sure this PR is against "dev", not "main".
  • Request a review from one of the current epipredict main reviewers:
    dajmcdon.
  • Make sure to bump the version number in DESCRIPTION and NEWS.md.
    Always increment the patch version number (the third number), unless you are
    making a release PR from dev to main, in which case increment the minor
    version number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    0.7.2, then write your changes under the 0.8 heading).
  • Consider pinning the epiprocess version in the DESCRIPTION file if
    • You anticipate breaking changes in epiprocess soon
    • You want to co-develop features in epipredict and epiprocess

Change explanations for reviewer

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

@rnayebi21 rnayebi21 requested a review from dshemetov August 13, 2024 22:25
@rnayebi21 rnayebi21 requested a review from dajmcdon as a code owner August 13, 2024 22:25
Copy link
Contributor

@dshemetov dshemetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@dajmcdon
Copy link
Contributor

Can you undo the changes to NEWS.md and DESCRIPTION? Those aren't necessary for a bug fix as small as this.

@rnayebi21
Copy link
Contributor Author

Can you undo the changes to NEWS.md and DESCRIPTION? Those aren't necessary for a bug fix as small as this.

Sounds good. Just undid the changes.

@rnayebi21 rnayebi21 merged commit 3191742 into dev Aug 13, 2024
2 checks passed
@dshemetov dshemetov deleted the r/fix branch August 13, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vignette issue: epiprocess time type
3 participants