Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

352 remove all instances of epi keys #373

Merged
merged 16 commits into from
Aug 29, 2024

Conversation

dajmcdon
Copy link
Contributor

@dajmcdon dajmcdon commented Aug 28, 2024

Checklist

Please:

  • Make sure this PR is against "dev", not "main".
  • Request a review from one of the current epipredict main reviewers:
    dajmcdon.
  • Make sure to bump the version number in DESCRIPTION and NEWS.md.
    Always increment the patch version number (the third number), unless you are
    making a release PR from dev to main, in which case increment the minor
    version number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    0.7.2, then write your changes under the 0.8 heading).

Change explanations for reviewer

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

@dajmcdon dajmcdon linked an issue Aug 28, 2024 that may be closed by this pull request
@dajmcdon
Copy link
Contributor Author

This PR also cleans out piles of improper prefixing (some needed, some not). The only files that need review are

  1. R/key_colnames.R
  2. tests/testthat/test-key_colnames.R
  3. R/step_population_scaling.R
  4. R/layer_population_scaling.R

@dshemetov dshemetov self-requested a review August 28, 2024 17:24
Copy link
Contributor

@dshemetov dshemetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i only looked at the files you mentioned above and only had a few minor nit-type comments. overall looks good, thanks for looking into population_scaling!

R/key_colnames.R Outdated Show resolved Hide resolved
tests/testthat/test-key_colnames.R Outdated Show resolved Hide resolved
tests/testthat/test-key_colnames.R Show resolved Hide resolved
tests/testthat/test-population_scaling.R Outdated Show resolved Hide resolved
R/layer_population_scaling.R Show resolved Hide resolved
@dajmcdon dajmcdon merged commit b4d4071 into dev Aug 29, 2024
2 checks passed
@dajmcdon dajmcdon deleted the 352-remove-all-instances-of-epi_keys branch August 29, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all instances of epi_keys() Refactor step_population_scaling refactor *_population_scaling()
2 participants