Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain epi df class #379

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Retain epi df class #379

merged 3 commits into from
Sep 30, 2024

Conversation

dajmcdon
Copy link
Contributor

Checklist

Please:

  • Make sure this PR is against "dev", not "main".
  • Make sure to bump the version number in DESCRIPTION and NEWS.md.
    Always increment the patch version number (the third number), unless you are
    making a release PR from dev to main, in which case increment the minor
    version number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    0.7.2, then write your changes under the 0.8 heading).

Change explanations for reviewer

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

@dajmcdon dajmcdon requested a review from dsweber2 September 12, 2024 22:45
@dsweber2
Copy link
Contributor

How does this effect #370, deprecating the epi_recipe?

@dajmcdon
Copy link
Contributor Author

dajmcdon commented Sep 12, 2024

This is a short term fix. That one is far more major (but still won't quite fix this problem). This fix is actually there as well. (Where by "fix" I mean, to the best of our ability.)

Copy link
Contributor

@dshemetov dshemetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a nice-to-have partial fix.

Note: this flag activates a hook in epiprocess::as_tibble.epi_df which attempts to preserve the metadata in the returned tibble. Naturally, appending metadata to an existing class comes with no guarantees that it will be preserved or that it won't interfere with other aspects of the class, but (a) it seems unlikely that we will have issues here, (b) very very hard to understand the downstream consequences without actually trying this, so I think we should go ahead with it.

Need to fix: version number in DESCRIPTION.

@dshemetov dshemetov merged commit db2cfee into dev Sep 30, 2024
2 checks passed
@dshemetov dshemetov deleted the retain-epi_df-class branch September 30, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Steps sometimes destroy the epi_df
3 participants