Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: snapshot rest of the errors #393

Merged
merged 1 commit into from
Sep 30, 2024
Merged

tests: snapshot rest of the errors #393

merged 1 commit into from
Sep 30, 2024

Conversation

dshemetov
Copy link
Contributor

Checklist

Please:

  • Make sure this PR is against "dev", not "main".
  • Request a review from one of the current epipredict main reviewers:
    dajmcdon.
  • Make sure to bump the version number in DESCRIPTION and NEWS.md.
    Always increment the patch version number (the third number), unless you are
    making a release PR from dev to main, in which case increment the minor
    version number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    0.7.2, then write your changes under the 0.8 heading).
  • Consider pinning the epiprocess version in the DESCRIPTION file if
    • You anticipate breaking changes in epiprocess soon
    • You want to co-develop features in epipredict and epiprocess

Change explanations for reviewer

Noticed that we have many bare expect_error tests, so I went ahead and snapshotted them. Didn't look too closely at the messages, but this should at least help us detect when the errors change in the future.

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

  • Resolves #{issue number}

@dshemetov dshemetov requested a review from dajmcdon as a code owner September 30, 2024 21:23
@dajmcdon
Copy link
Contributor

@dshemetov Are you anticipating anything else here? It looks like everything else in #391 is done. So this, then that.

@dshemetov
Copy link
Contributor Author

Nope this should be good to go 👍

@dajmcdon dajmcdon merged commit 36c4c0a into dev Sep 30, 2024
2 checks passed
@dajmcdon dajmcdon deleted the ds/snapshots branch September 30, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants