Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardhat quantiles #400

Draft
wants to merge 51 commits into
base: v0.2.0
Choose a base branch
from
Draft

Hardhat quantiles #400

wants to merge 51 commits into from

Conversation

dajmcdon
Copy link
Contributor

@dajmcdon dajmcdon commented Oct 2, 2024

Checklist

Please:

  • Make sure this PR is against "dev", not "main".
  • Request a review from one of the current epipredict main reviewers:
    dajmcdon.
  • Make sure to bump the version number in DESCRIPTION and NEWS.md.
    Always increment the patch version number (the third number), unless you are
    making a release PR from dev to main, in which case increment the minor
    version number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    0.7.2, then write your changes under the 0.8 heading).
  • Consider pinning the epiprocess version in the DESCRIPTION file if
    • You anticipate breaking changes in epiprocess soon
    • You want to co-develop features in epipredict and epiprocess

Change explanations for reviewer

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

  • Resolves #{issue number}

dajmcdon and others added 30 commits September 11, 2024 13:49
@dajmcdon
fix and add test
dd9c92e
@dajmcdon
bump version, news
9b47549
@dajmcdon
try to retain the class to the extent possible
fbceb88
@dajmcdon
bump version
9cf5b85
@dajmcdon
import rlang checks since checkmate doesn't take an environment
4d8a24d
@dajmcdon
current tests pass
73579e5
@dajmcdon
replace expect_error with expect_snapshot to log the message as well
79c56fc
@dajmcdon
adjust imports and document
0d1064a
@dajmcdon
create snapshot tests
96d5b9f
@dajmcdon
news, bump version, run styler
1822985
@dsweber2
make internal versioning accurate
f7fec68
@dshemetov
Merge pull request #385 from cmu-delphi/epiprocessUpperBound
070cb1d 
make internal versioning accurate
@dajmcdon
add missing topic
acaca4f
@dajmcdon
Merge pull request #388 from cmu-delphi/fix-failing-pkgdown
cd12775 
add missing topic
@dshemetov @dajmcdon
fix: update for compatibility with epiprocess==0.9.0
0e7d90f 
Co-authored-by: Daniel McDonald <[email protected]>
@dshemetov
styler: style
b3e3189
@dshemetov
doc: fix vignettes
374cb2f
@dshemetov
Merge pull request #386 from cmu-delphi/ds/epiprocess-0.9.0
34cb6ed 
fix: update for compatibility with epiprocess==0.9.0
@dshemetov
doc: fix sliding article and verify others
93a405e
@dshemetov
Merge pull request #392 from cmu-delphi/ds/fix-articles
525618a 
doc: fix sliding article and verify others
@dajmcdon
Merge branch 'dev' into retain-epi_df-class
9c35fb9
@dajmcdon
error if not an epidf in epirecipe
1caa549
@dshemetov
test: snapshot step_* errors
37d2352
@dshemetov
Merge branch 'dev' into 287-surface-step-name
7222b36
@dshemetov
repo: bump version
78fbaa0
@dajmcdon
redocument
bffc03b
@dshemetov
test: add new snapshots
65385e2
@dshemetov
Merge pull request #379 from cmu-delphi/retain-epi_df-class
db2cfee 
Retain epi df class
@dshemetov
repo: bump version
addb2ae
@dshemetov
Merge branch 'dev' into 363-no-drop-epiwf-class
de0add1
dshemetov and others added 21 commits September 30, 2024 13:23
@dshemetov
Merge pull request #377 from cmu-delphi/363-no-drop-epiwf-class
1c01028 
fit() no longer drops the epi_workflow class
@dshemetov
Merge branch 'dev' into 287-surface-step-name
1ff2efc
@dshemetov
repo: bump version
434262a
@dajmcdon
Merge pull request #383 from cmu-delphi/287-surface-step-name
37f3ad0 
287 surface step name
@dshemetov
repo: fix imports and remove unused standalone files
cebc672
@dshemetov
tests: snapshot tests on errors
f588f0a
@dajmcdon
Merge pull request #395 from cmu-delphi/ds/dependencies
0bb8a35 
repo: fix imports and remove unused standalone files
@dajmcdon
Merge pull request #393 from cmu-delphi/ds/snapshots
36c4c0a 
tests: snapshot rest of the errors
@dajmcdon
skeleton
b74c039
@dajmcdon
bump version, promote authors, add funder
aa41827
@dajmcdon
add math ops, test
7ee015a
@dajmcdon
pass tests
44da76d
@dshemetov
Merge pull request #391 from cmu-delphi/dev
56d927a 
Sync main with dev, epiprocess 0.9.0
@dajmcdon
woodshedding wis
faa9440
@dajmcdon
pass local tests
2646b0e
@dajmcdon
strange unpassable snapshot test
b4fa6e6
@dajmcdon
remove old snap
be4fd5d
@dajmcdon
excise dist_quantiles and nested_quantiles
0167700
@dajmcdon
merge main due to epiprocess dependencies
dd5f555 
Merge branch 'main' into hardhat-quantiles

# Conflicts:
#	DESCRIPTION
#	R/cdc_baseline_forecaster.R
#	R/epi_recipe.R
#	R/flusight_hub_formatter.R
#	R/step_epi_slide.R
#	man/cdc_baseline_forecaster.Rd
#	man/flusight_hub_formatter.Rd
#	man/step_epi_slide.Rd
#	tests/testthat/_snaps/pivot_quantiles.md
#	tests/testthat/test-check_enough_train_data.R
#	tests/testthat/test-dist_quantiles.R
#	tests/testthat/test-epi_recipe.R
#	tests/testthat/test-key_colnames.R
#	tests/testthat/test-pivot_quantiles.R
#	tests/testthat/test-step_epi_shift.R
#	tests/testthat/test-step_epi_slide.R
#	tests/testthat/test-step_training_window.R
#	tests/testthat/test-wis-quantile_pred.R
@dajmcdon
all tests pass
87e5163
@dajmcdon
tests/checks pass. done.
3d58952
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dajmcdon @dsweber2 @dshemetov