Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove Suggests dependence on covidcast #402

Merged
merged 4 commits into from
Oct 16, 2024
Merged

refactor: remove Suggests dependence on covidcast #402

merged 4 commits into from
Oct 16, 2024

Conversation

dshemetov
Copy link
Contributor

@dshemetov dshemetov commented Oct 3, 2024

Checklist

Please:

  • Make sure this PR is against "dev", not "main".
  • Request a review from one of the current epipredict main reviewers:
    dajmcdon.
  • Make sure to bump the version number in DESCRIPTION and NEWS.md.
    Always increment the patch version number (the third number), unless you are
    making a release PR from dev to main, in which case increment the minor
    version number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    0.7.2, then write your changes under the 0.8 heading).
  • Consider pinning the epiprocess version in the DESCRIPTION file if
    • You anticipate breaking changes in epiprocess soon
    • You want to co-develop features in epipredict and epiprocess

Change explanations for reviewer

  • just download the state data file, don't import covidcast
  • covidcast depends on sf which is tough to install (it just refuses to compile on my machine) and my renv keeps trying to install ALL dependencies

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

  • Resolves #{issue number}

* just download the state data file, don't import covidcast
* covidcast depends on sf which is tough to install
@dshemetov dshemetov requested a review from dajmcdon as a code owner October 3, 2024 01:58
@dajmcdon dajmcdon merged commit e53af97 into dev Oct 16, 2024
2 checks passed
@dajmcdon dajmcdon deleted the ds/file branch October 16, 2024 16:28
@dsweber2 dsweber2 restored the ds/file branch October 16, 2024 20:14
@dsweber2
Copy link
Contributor

This needed a rebase before merging

@dsweber2
Copy link
Contributor

I'm actually getting different errors than the ones that the merge got. Not sure why it isn't finding the jhu data

@dshemetov dshemetov deleted the ds/file branch October 16, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants