Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorting unsorted quantiles #420

Closed
wants to merge 1 commit into from
Closed

sorting unsorted quantiles #420

wants to merge 1 commit into from

Conversation

dsweber2
Copy link
Contributor

Checklist

Please:

  • Make sure this PR is against "dev", not "main".
  • Request a review from one of the current epipredict main reviewers:
    dajmcdon.
  • Make sure to bump the version number in DESCRIPTION and NEWS.md.
    Always increment the patch version number (the third number), unless you are
    making a release PR from dev to main, in which case increment the minor
    version number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    0.7.2, then write your changes under the 0.8 heading).
  • Consider pinning the epiprocess version in the DESCRIPTION file if
    • You anticipate breaking changes in epiprocess soon
    • You want to co-develop features in epipredict and epiprocess

Change explanations for reviewer

The quantile sorting issue continues to crop up somehow.

@dsweber2 dsweber2 requested a review from dajmcdon as a code owner October 25, 2024 18:53
@dajmcdon
Copy link
Contributor

I'm going to close this. The problem is upstream: requested quantiles must be passed to rand_forest("regression") |> set_engine("grf_quantiles", quantiles = c(.01, .025, 1:19 / 20, .975, .99)).

@dajmcdon dajmcdon closed this Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants