Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define case_num var when pulling data from epidatasets in symptoms survey vignette #423

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

nmdefries
Copy link
Contributor

@nmdefries nmdefries commented Oct 30, 2024

Checklist

Please:

  • Make sure this PR is against "dev", not "main".
  • Request a review from one of the current epipredict main reviewers:
    dajmcdon.
  • Make sure to bump the version number in DESCRIPTION and NEWS.md.
    Always increment the patch version number (the third number), unless you are
    making a release PR from dev to main, in which case increment the minor
    version number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    0.7.2, then write your changes under the 0.8 heading).
  • Consider pinning the epiprocess version in the DESCRIPTION file if
    • You anticipate breaking changes in epiprocess soon
    • You want to co-develop features in epipredict and epiprocess

Change explanations for reviewer

Define case_num to keep vignette build from failing. Although it's no longer used for generating data, it is used in plot text.

@nmdefries nmdefries requested a review from dajmcdon as a code owner October 30, 2024 22:54
@dajmcdon dajmcdon merged commit b73105f into dev Nov 11, 2024
2 checks passed
@dajmcdon dajmcdon deleted the ndefries/vignette-eval-var branch November 11, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants