Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for dist_quantile all NA s #429

Merged
merged 4 commits into from
Dec 16, 2024
Merged

fix for dist_quantile all NA s #429

merged 4 commits into from
Dec 16, 2024

Conversation

dsweber2
Copy link
Contributor

@dsweber2 dsweber2 commented Dec 12, 2024

Checklist

Please:

  • Make sure this PR is against "dev", not "main".
  • Request a review from one of the current epipredict main reviewers:
    dajmcdon.
  • Make sure to bump the version number in DESCRIPTION and NEWS.md.
    Always increment the patch version number (the third number), unless you are
    making a release PR from dev to main, in which case increment the minor
    version number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    0.7.2, then write your changes under the 0.8 heading).
  • Consider pinning the epiprocess version in the DESCRIPTION file if
    • You anticipate breaking changes in epiprocess soon
    • You want to co-develop features in epipredict and epiprocess

Change explanations for reviewer

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

@dsweber2 dsweber2 requested a review from dajmcdon as a code owner December 12, 2024 22:37
@dsweber2
Copy link
Contributor Author

This actually broke b/c of some changes to epiprocess' interface in an unrelated vignette. I added a fix for that. It changes the name of the slide column from cr_7dav to case_rate_7dav

@dsweber2 dsweber2 merged commit abcdd0b into dev Dec 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quantile() method for dist_quantiles should produce NAs as needed, not error
2 participants