Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid inclusion of epikeys in roll_iqr #575

Closed
brookslogan opened this issue Nov 28, 2024 · 1 comment · Fixed by #564
Closed

Avoid inclusion of epikeys in roll_iqr #575

brookslogan opened this issue Nov 28, 2024 · 1 comment · Fixed by #564

Comments

@brookslogan
Copy link
Contributor

No description provided.

@brookslogan
Copy link
Contributor Author

brookslogan commented Nov 28, 2024

Using detect_outlr_rm spams messages like

Adding missing grouping variables: `geo_value`

as it's using epi_slide which now autogroups, followed by dplyr::select([stuff that doesn't explicitly include epikey cols]).

Might be addressed by #564, which ungroups after slides if we autogrouped.

This also causes name conflicts if we try to unpack the outlier info because we now have duplicate epikey columns packed in the outlier info. (Workaround is to |> unnest() and ignore the advice to provide cols because providing cols also causes it to complain about naming conflicts.)

@brookslogan brookslogan changed the title Avoid messages about adding grouping variables in select in roll_iqr Avoid inclusion of epikeys in roll_iqr Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant