Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust epi_slide_opt output naming; adjust epi_slide* autogrouping; fix tidyselect issue #564

Merged
merged 28 commits into from
Dec 9, 2024

Conversation

brookslogan
Copy link
Contributor

@brookslogan brookslogan commented Nov 8, 2024

Checklist

Please:

  • Make sure this PR is against "dev", not "main" (unless this is a release
    PR).
  • Request a review from one of the current main reviewers:
    brookslogan, nmdefries.
  • Makes sure to bump the version number in DESCRIPTION. Always increment
    the patch version number (the third number), unless you are making a
    release PR from dev to main, in which case increment the minor version
    number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    1.7.2, then write your changes under the 1.8 heading).
  • See DEVELOPMENT.md for more information on the development
    process.

Change explanations for reviewer

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

@brookslogan brookslogan force-pushed the lcb/epi_slide_opt-output-renaming branch 4 times, most recently from 7a8ec75 to 85503c1 Compare November 8, 2024 19:35
@brookslogan brookslogan force-pushed the lcb/epi_slide_opt-output-renaming branch 5 times, most recently from 1627870 to e6f7264 Compare November 12, 2024 02:18
@brookslogan
Copy link
Contributor Author

brookslogan commented Nov 12, 2024

  • resolve styler vs linter opinions on line length
  • check whether naming overrides forwarded through _mean and _sum
  • [-] add .prefix and .suffix naming features to base epi[x]_slide(?) --- but they are not the same feature... .prefix and .suffix for epi[x]_slide would be on the output columns, not on the input columns, and would not need to be glue syntax... might be confusing.
  • Update NEWS.md
  • [-] vignette updates?
    • Just did minimal changes to keep them running for now. Really should present epi_slide_{sum,mean} first, then the general version.
  • auto-grouping&ungrouping by epikey, and ensure epi_slide also auto-ungroups if auto-grouping?
  • Update epipredict to not break
    • No update should be needed; epi_slide_opt & co. currently aren't used in epipredict.

@brookslogan brookslogan force-pushed the lcb/epi_slide_opt-output-renaming branch from e6f7264 to 6a22c4b Compare November 12, 2024 19:55
- BREAKING CHANGE: adjust default output column naming scheme, disallow
  overwriting columns.
@brookslogan brookslogan force-pushed the lcb/epi_slide_opt-output-renaming branch 2 times, most recently from 882e960 to 9669773 Compare November 12, 2024 20:59
@brookslogan brookslogan force-pushed the lcb/epi_slide_opt-output-renaming branch from fdc9ee7 to 79ed2f3 Compare November 12, 2024 22:42
- Show naming options, including with multi-column selections when we have
  accommodating example data sets
- Select away the pre-existing 7d aggregations in the example data set
- Ungroup output
@brookslogan brookslogan force-pushed the lcb/epi_slide_opt-output-renaming branch from 845f4c0 to beb434c Compare November 14, 2024 20:51
@brookslogan brookslogan force-pushed the lcb/epi_slide_opt-output-renaming branch from 45170b1 to f9a8356 Compare November 14, 2024 21:29
@brookslogan brookslogan force-pushed the lcb/epi_slide_opt-output-renaming branch from ed23df0 to 6d8bcf6 Compare November 14, 2024 21:43
@brookslogan brookslogan marked this pull request as ready for review November 14, 2024 21:44
@brookslogan brookslogan changed the title Lcb/epi slide opt output renaming Adjust epi_slide_opt output naming; adjust epi_slide* autogrouping; fix tidyselect bug Nov 14, 2024
@brookslogan brookslogan changed the title Adjust epi_slide_opt output naming; adjust epi_slide* autogrouping; fix tidyselect bug Adjust epi_slide_opt output naming; adjust epi_slide* autogrouping; fix tidyselect issue Nov 14, 2024
@nmdefries nmdefries self-requested a review November 14, 2024 21:58
We may later need it to make default args, in which case we should probably
export to be less "magical".
@brookslogan
Copy link
Contributor Author

@nmdefries sorry for all the noise here; I tried to implement just 1 time utility from #494 but forgot it actually relied on the concept of a "unit" time delta/step; fixed that up and added the unit time step helper. Think that's fixed now. Also fixed some CHECK issues.

The core changes, and now these helpers, should hopefully be ready now.

R/slide.R Outdated Show resolved Hide resolved
R/slide.R Outdated Show resolved Hide resolved
R/slide.R Show resolved Hide resolved
R/slide.R Show resolved Hide resolved
R/slide.R Outdated Show resolved Hide resolved
R/slide.R Show resolved Hide resolved
R/slide.R Show resolved Hide resolved
tests/testthat/test-epi_slide.R Show resolved Hide resolved
@brookslogan brookslogan force-pushed the lcb/epi_slide_opt-output-renaming branch from ec243a8 to 95b485f Compare November 26, 2024 13:21
@brookslogan brookslogan force-pushed the lcb/epi_slide_opt-output-renaming branch from 95b485f to 081bd22 Compare November 26, 2024 13:23
@brookslogan brookslogan force-pushed the lcb/epi_slide_opt-output-renaming branch from 83a9618 to b4bacf8 Compare November 26, 2024 18:23
Copy link
Contributor

@nmdefries nmdefries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This is ready to merge aside from failing tests (looks like dplyr isn't loaded in examples).

@brookslogan brookslogan merged commit 5958a76 into dev Dec 9, 2024
5 checks passed
@brookslogan brookslogan deleted the lcb/epi_slide_opt-output-renaming branch December 9, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants