-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust epi_slide_opt
output naming; adjust epi_slide*
autogrouping; fix tidyselect issue
#564
Conversation
7a8ec75
to
85503c1
Compare
1627870
to
e6f7264
Compare
|
e6f7264
to
6a22c4b
Compare
- BREAKING CHANGE: adjust default output column naming scheme, disallow overwriting columns.
882e960
to
9669773
Compare
fdc9ee7
to
79ed2f3
Compare
- Show naming options, including with multi-column selections when we have accommodating example data sets - Select away the pre-existing 7d aggregations in the example data set - Ungroup output
845f4c0
to
beb434c
Compare
45170b1
to
f9a8356
Compare
ed23df0
to
6d8bcf6
Compare
epi_slide_opt
output naming; adjust epi_slide*
autogrouping; fix tidyselect bug
epi_slide_opt
output naming; adjust epi_slide*
autogrouping; fix tidyselect bugepi_slide_opt
output naming; adjust epi_slide*
autogrouping; fix tidyselect issue
We may later need it to make default args, in which case we should probably export to be less "magical".
@nmdefries sorry for all the noise here; I tried to implement just 1 time utility from #494 but forgot it actually relied on the concept of a "unit" time delta/step; fixed that up and added the unit time step helper. Think that's fixed now. Also fixed some CHECK issues. The core changes, and now these helpers, should hopefully be ready now. |
Co-authored-by: nmdefries <[email protected]>
Co-authored-by: nmdefries <[email protected]>
ec243a8
to
95b485f
Compare
95b485f
to
081bd22
Compare
83a9618
to
b4bacf8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. This is ready to merge aside from failing tests (looks like dplyr isn't loaded in examples).
Checklist
Please:
PR).
brookslogan, nmdefries.
DESCRIPTION
. Always incrementthe patch version number (the third number), unless you are making a
release PR from dev to main, in which case increment the minor version
number (the second number).
(backwards-incompatible changes to the documented interface) are noted.
Collect the changes under the next release number (e.g. if you are on
1.7.2, then write your changes under the 1.8 heading).
process.
Change explanations for reviewer
Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch
.suffix
(and.prefix
?) arguments to slides #542.)epi_slide_opt
work with!!varname
, maybe!!varnames
, maybe!!!varnames
#562.as_epi_df()
#560.as_epi_df
should ungroup input #573. (epipredict tests pass. epipredict bug identified, worked around, fix filed: cmu-delphi/epipredict#428)roll_iqr
#575