Autoload epidatasets as a dependency rather than reexporting epidatasets data

[nmdefries]

Checklist

Please:

• Make sure this PR is against "dev", not "main" (unless this is a release
  PR).
• Request a review from one of the current main reviewers:
  brookslogan, nmdefries.
• Makes sure to bump the version number in DESCRIPTION. Always increment
  the patch version number (the third number), unless you are making a
  release PR from dev to main, in which case increment the minor version
  number (the second number).
• Describe changes made in NEWS.md, making sure breaking changes
  (backwards-incompatible changes to the documented interface) are noted.
  Collect the changes under the next release number (e.g. if you are on
  1.7.2, then write your changes under the 1.8 heading).
• See DEVELOPMENT.md for more information on the development
  process.

Change explanations for reviewer

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

• Resolves #{issue number}

[brookslogan]

Could you give an overview of the pros/cons of this change? I think I ended up adjusting things trying to make checks run over in #564, but I remember feeling forced into some approach to satisfy both R CMD CHECK and pkgdown checks simultaneously, and don't remember how that approach ended up "feeling". Does CRAN suggest against Depends:?

[nmdefries]

Pros for this change:

• matches the approach used in epipredict
• from experience with epipredict, speeds up documenting
• don't need to redocument this package whenever epidatasets changes

Cons:

• Adds a Depends:
• "if your package relies on a package A which itself "Depends" on another package B, your package will likely need to attach A with a "Depends" directive. This is because the functions in package A were written with the expectation that package B and its functions would be attached to the search() path" source ("likely"?). This is old and not mentioned in the R Packages book, so unclear if this is a theoretical or perhaps resolved issue. I haven't found additional information yet.

Neutrals:

• Depends are considered less safe than Imports because of possible name collisions in the search path. This is very unlikely to impact us; the data objects we are making available have fairly long and specific names.

No specific guidelines about Depends vs Imports in the CRAN policies.

[brookslogan]

Thanks for recording this!

Notes:

• The approach in Adjust epi_slide_opt output naming; adjust epi_slide* autogrouping; fix tidyselect issue #564 also allows for not having to re-document() when epidatasets is updated, unless object names change etc. IIRC it did have a sort of useless/annoying re-export doc page though.

"if your package relies on a package A which itself "Depends" on another package B, your package will likely need to attach A with a "Depends" directive. This is because the functions in package A were written with the expectation that package B and its functions would be attached to the search() path" source ("likely"?). This is old and not mentioned in the R Packages book, so unclear if this is a theoretical or perhaps resolved issue. I haven't found additional information yet.

• I'd be very surprised if this is the case. They say that '''An "Imports" directive will load but not attach package A and will neither load nor attach package B.''', but the whole thing with Depends: is that simply loading (not attaching) a package with attach its Depends: packages; I don't know why the behavior would be changed simply because it was transitively loaded via Imports: of another package.

Depends are considered less safe than Imports because of possible name collisions in the search path. This is very unlikely to impact us; the data objects we are making available have fairly long and specific names.

Right, I doubt we are going to have name collisions. Just maybe some annoying junk in completion options.

[brookslogan]

• todo: resolve merge conflicts. Probably at least version number and where the NEWS entry goes because we did a 0.10.0 release for the workshop.