Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Djm/autoplot #382

Merged
merged 31 commits into from
Feb 6, 2024
Merged

Djm/autoplot #382

merged 31 commits into from
Feb 6, 2024

Conversation

dajmcdon
Copy link
Contributor

@dajmcdon dajmcdon commented Nov 27, 2023

Adds autoplot() functionality and some helpers.

Needs #377 to pass checks.

See also

  • cmu-delphi/forecasting-team-meta#15
  • cmu-delphi/covid-hosp-forecast#94

@dsweber2 dsweber2 added this to the Epiprocess Issue Triage milestone Dec 6, 2023
R/epi_keys.R Outdated Show resolved Hide resolved
@brookslogan brookslogan requested a review from nmdefries January 18, 2024 21:21
@dajmcdon dajmcdon requested a review from brookslogan January 20, 2024 00:13
Copy link
Contributor

@nmdefries nmdefries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unable to get a some of autoplot behavior to work. Specifics below.

DESCRIPTION Outdated Show resolved Hide resolved
R/key_colnames.R Outdated Show resolved Hide resolved
R/utils.R Show resolved Hide resolved
R/utils-arg.R Outdated Show resolved Hide resolved
R/autoplot.R Show resolved Hide resolved
R/utils-arg.R Outdated Show resolved Hide resolved
R/autoplot.R Show resolved Hide resolved
R/autoplot.R Show resolved Hide resolved
R/autoplot.R Outdated Show resolved Hide resolved
@nmdefries
Copy link
Contributor

thought: Could be nice to be able to change the color scheme. That may be too feature-ful for autoplot, though.

dajmcdon and others added 8 commits January 25, 2024 09:05
Using an external vector in selections was deprecated in tidyselect 1.1.0.
i Please use `all_of()` or `any_of()` instead.
  # Was:
  data %>% select(geo_and_other_keys)

  # Now:
  data %>% select(all_of(geo_and_other_keys))
@dajmcdon
Copy link
Contributor Author

dajmcdon commented Feb 3, 2024

@brookslogan Trying to document to regenerate the NAMESPACE. I'm hitting:

devtools::document()
ℹ Updating epiprocess documentationLoading epiprocess
Error: 'archive_cases_dv_subset' is not an exported object from 'namespace:epiprocess'

Followed by:

devtools::document()
ℹ Updating epiprocess documentationLoading epiprocess
Error in `withCallingHandlers()` at epiprocess/R/data.R:137:7:
! An error was raised while attempting to evaluate a promise (prepared
with `delayed_assign_with_unregister_awareness`) while an `unregister` or
`unregister_namespace` call was being evaluated. This can happen, for example,
when `devtools::load_all` reloads a package that contains a buggy promise,
because reloading can cause old package-level promises to be forced via
`pkgload::unregister` and `pkgload:::unregister_namespace`, due to
https://github.com/r-lib/pkgload/pull/157. If this is the current situation,
you might be able to be successfully reload the package again after
`unloadNamespace`-ing it (but this situation will keep re-occurring every
other `devtools::load` and every `devtools:document` until the bug or
situation generating the promise's error has been resolved).
Caused by error in `as.data.table()`:
! could not find function "as.data.table"
Run `rlang::last_trace()` to see where the error occurred.

@dajmcdon dajmcdon merged commit 7ae9e87 into dev Feb 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add plotting tools?
5 participants