-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: unclutter epi_archive print method #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshemetov
commented
Jan 30, 2024
dshemetov
commented
Jan 30, 2024
dshemetov
commented
Jan 30, 2024
dshemetov
commented
Jan 30, 2024
dshemetov
commented
Jan 30, 2024
dshemetov
commented
Jan 30, 2024
dshemetov
commented
Jan 30, 2024
dshemetov
commented
Jan 30, 2024
dshemetov
commented
Jan 30, 2024
brookslogan
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what we had in mind for adding the DT snippet, but these remain:
exclude any redundant information
and
move some other information into a summary method
- The first can be resolved pretty easily here (see code convos).
- Second involves more opinions & could be spun off to a separate lower-priority Issue.
question: do you know if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please:
brookslogan, nmdefries.
DESCRIPTION
andNEWS.md
.Always increment the patch version number (the third number), unless you are
making a release PR from dev to main, in which case increment the minor
version number (the second number).
(backwards-incompatible changes to the documented interface) are noted.
Collect the changes under the next release number (e.g. if you are on
0.7.2, then write your changes under the 0.8 heading).
Change explanations for reviewer
key(DT) - c("geo_value", "time_value", "version")
x$DT %>% print
at the endMagic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch
epi_archive
'sprint
method + add preview ofDT
#341