Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: unclutter epi_archive print method #412

Merged
merged 4 commits into from
Jan 31, 2024
Merged

refactor: unclutter epi_archive print method #412

merged 4 commits into from
Jan 31, 2024

Conversation

dshemetov
Copy link
Contributor

@dshemetov dshemetov commented Jan 30, 2024

Checklist

Please:

  • Make sure this PR is against "dev", not "main".
  • Request a review from one of the current epiprocess main reviewers:
    brookslogan, nmdefries.
  • Makes sure to bump the version number in DESCRIPTION and NEWS.md.
    Always increment the patch version number (the third number), unless you are
    making a release PR from dev to main, in which case increment the minor
    version number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    0.7.2, then write your changes under the 0.8 heading).

Change explanations for reviewer

  • Removed some metadata prints and combined a few others into a single line
  • Added a line that prints key(DT) - c("geo_value", "time_value", "version")
  • Added a x$DT %>% print at the end

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

@dshemetov dshemetov requested a review from brookslogan January 30, 2024 00:02
R/methods-epi_archive.R Outdated Show resolved Hide resolved
R/methods-epi_archive.R Outdated Show resolved Hide resolved
R/methods-epi_archive.R Outdated Show resolved Hide resolved
R/methods-epi_archive.R Outdated Show resolved Hide resolved
R/methods-epi_archive.R Outdated Show resolved Hide resolved
R/methods-epi_archive.R Outdated Show resolved Hide resolved
R/methods-epi_archive.R Outdated Show resolved Hide resolved
R/methods-epi_archive.R Outdated Show resolved Hide resolved
R/methods-epi_archive.R Outdated Show resolved Hide resolved
Copy link
Contributor

@brookslogan brookslogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what we had in mind for adding the DT snippet, but these remain:

exclude any redundant information

and

move some other information into a summary method

  • The first can be resolved pretty easily here (see code convos).
  • Second involves more opinions & could be spun off to a separate lower-priority Issue.

R/methods-epi_archive.R Outdated Show resolved Hide resolved
R/archive.R Show resolved Hide resolved
R/methods-epi_archive.R Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@brookslogan
Copy link
Contributor

question: do you know if Warning: <anonymous>: ... may be used in an incorrect context in the checks was pre-existing?

@dshemetov dshemetov merged commit 511c5e3 into dev Jan 31, 2024
2 checks passed
@dshemetov dshemetov deleted the ds/print branch January 31, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclutter epi_archive's print method + add preview of DT
2 participants