Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppression noisy test warnings #470

Merged
merged 6 commits into from
Jul 10, 2024
Merged

Conversation

nmdefries
Copy link
Contributor

@nmdefries nmdefries commented Jun 20, 2024

Checklist

Please:

  • Make sure this PR is against "dev", not "main" (unless this is a release
    PR).
  • Request a review from one of the current main reviewers:
    brookslogan, nmdefries.
  • Makes sure to bump the version number in DESCRIPTION. Always increment
    the patch version number (the third number), unless you are making a
    release PR from dev to main, in which case increment the minor version
    number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    1.7.2, then write your changes under the 1.8 heading).
  • See DEVELOPMENT.md for more information on the development
    process.

Change explanations for reviewer

Suppression noisy test warnings.

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

Partially addresses #465

@nmdefries nmdefries changed the base branch from ndefries/dots-warning to dev June 20, 2024 20:45
@nmdefries nmdefries changed the base branch from dev to ndefries/dots-warning June 20, 2024 20:59
@nmdefries nmdefries requested a review from brookslogan June 20, 2024 22:10
Base automatically changed from ndefries/dots-warning to dev June 21, 2024 01:50
R/utils.R Outdated Show resolved Hide resolved
@brookslogan brookslogan self-requested a review July 8, 2024 18:14
Copy link
Contributor

@brookslogan brookslogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Not so nice: CI's not letting me admire the clean(er?) check output. Any idea why?

Please resolve small issue above regarding deprecated().

@nmdefries nmdefries force-pushed the ndefries/warning-suppression branch from 3807ed3 to ebfba0d Compare July 10, 2024 19:09
@nmdefries nmdefries merged commit 5fb62f3 into dev Jul 10, 2024
5 checks passed
@nmdefries nmdefries deleted the ndefries/warning-suppression branch July 10, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants