-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import datasets and documentation from epidatasets #520
Conversation
85e240f
to
acab84e
Compare
acab84e
to
ad225b2
Compare
Failing |
This also needs to rebuild docs and add |
72b8e91
to
e04f5a7
Compare
fa93d3f
to
b6a7d58
Compare
Cumulative death data is in tibble format and isn't really the type of data we expect in many functions. Probably not good to make it too accessible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed some tweaks; please
- double-check tweaks
Only blocker to merging:
- double-checking whether correlation vignette changes were intentional/okay. If they weren't intentional & you want me to check if changes are okay, please ping me / re-request review.
Others comments are ideas for the future; could you refile to issues if you think it makes sense? Not sure what doc overhaul is going to look like.
Wait, there is also
|
This now depends on cmu-delphi/epidatasets#5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a bit more to the NEWS.md entry; merging.
Trying to fix up CHECKs now. |
We inherit some soft CHECK complaints from cmu-delphi/epidatasets#10 but I'm going to go ahead and merge. |
Checklist
Please:
PR).
brookslogan, nmdefries.
DESCRIPTION
. Always incrementthe patch version number (the third number), unless you are making a
release PR from dev to main, in which case increment the minor version
number (the second number).
(backwards-incompatible changes to the documented interface) are noted.
Collect the changes under the next release number (e.g. if you are on
1.7.2, then write your changes under the 1.8 heading).
process.
Change explanations for reviewer
Reexport datasets from
epidatasets
, inheriting all associated documentation. Add data attribution -- since license info is included in dataset documentation, this is just adding data contributors to DESCRIPTION.Supersedes #344
Closes #327