catch main up to dev, epiprocess 0.9.0 #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from breaking changes or deprecations
- Correct check for whether data masking was used - Update checks and error messages for currently-accepted kinds of objects - Make some variable naming more consistent between files
to match `mutate` behavior
plus whitespace styling
Also move some things to @Keywords internal to match some recent additions, though it's still a mix.
Don't use deparse approach for now as it outputs ugly things like `structure(..........)` for multiple time classes and probably other classes. In the future, we may want to do something like a backport of deparse1 + special cases for time&other classes, for easier copy-paste for debugging while keeping readability.
Modern tidyselect distinguishes itself from data masking and prefers not having .data$, so just drop it. Attempt to appease linter with more globalVariables().
* key_colnames order change * replace kill_time_value with exclude arg in key_colnames * move duplicate time_values check in epi_slide
Slide improvements pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please:
PR).
brookslogan, nmdefries.
DESCRIPTION. Always incrementthe patch version number (the third number), unless you are making a
release PR from dev to main, in which case increment the minor version
number (the second number).
(backwards-incompatible changes to the documented interface) are noted.
Collect the changes under the next release number (e.g. if you are on
1.7.2, then write your changes under the 1.8 heading).
process.
Change explanations for reviewer
Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch