feat(epi[x]_slide): hint on forgotten syntax specifying comp #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brookslogan
force-pushed
the
lcb/hint-on-nontidy-f-force-errors
branch
2 times, most recently
from
fc256bb to
eb997a0
Compare
brookslogan
force-pushed
the
lcb/hint-on-nontidy-f-force-errors
branch
from
eb997a0 to
e5adcbd
Compare
dshemetov
reviewed
Oct 1, 2024
dshemetov
approved these changes
Oct 1, 2024
* Mention what's acceptable for yearmonth time_type * Mention Inf in validation errors as acceptable iff it's actually acceptable. * Reject any other strange "int" classes that pass test_int. (It rejects Date and POSIXt, but perhaps there are others.) * Refactor to use helper function test_sensible_int instead of test_int (as latter accepts difftimes and makes logic look confusing).
|
While addressing some lints & testing annoyances, I realized existing error messages may not hint enough for someone who is expecting @dshemetov If you have time, could you please take a look? Think it's ready to merge (DESCRIPTION, NEWS.md etc. up to date) if you think it looks good. (This might be new diffs, though apparently I was missing snapshot files originally so it's not that elucidating..) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please:
PR).
brookslogan, nmdefries.
DESCRIPTION. Always incrementthe patch version number (the third number), unless you are making a
release PR from dev to main, in which case increment the minor version
number (the second number).
(backwards-incompatible changes to the documented interface) are noted.
Collect the changes under the next release number (e.g. if you are on
1.7.2, then write your changes under the 1.8 heading).
process.
Change explanations for reviewer
Tries to provide some hints when a user has forgotten part of the syntax when specifying their slide computation, e.g., the tilde in a formula. It's just a hint so we don't false-diagnose e.g.
Perfectly distinguishing between forgotten syntax and the above type of error may allow us to just fix it up, but likely requires significantly more complex slide code, so we could try these hints first.
Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch
.fargument usage in epix_slide #529.