Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(complete.epi_df): fix backticks, tweak 1-line summary #559

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

brookslogan
Copy link
Contributor

@brookslogan brookslogan commented Oct 24, 2024

Checklist

Please:

  • Make sure this PR is against "dev", not "main" (unless this is a release
    PR).
  • [-] Request a review from one of the current main reviewers:
    brookslogan, nmdefries.
  • [-] Makes sure to bump the version number in DESCRIPTION. Always increment
    the patch version number (the third number), unless you are making a
    release PR from dev to main, in which case increment the minor version
    number (the second number).
  • [-] Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    1.7.2, then write your changes under the 1.8 heading).
  • See DEVELOPMENT.md for more information on the development
    process.

Change explanations for reviewer

  • @XuedaShen noticed an issues with the code formatting.

2024-10-24-154754_766x86_scrot

This fixes that + tweaks the summary. Don't think it's worth version bump or news entry given all the other doc changes.

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

@brookslogan brookslogan requested a review from dshemetov October 24, 2024 22:56
@brookslogan brookslogan marked this pull request as ready for review October 24, 2024 23:08
@dshemetov dshemetov merged commit 2ef8914 into dev Oct 25, 2024
5 checks passed
@dshemetov dshemetov deleted the lcb/fix-complete-doc-quoting branch October 25, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants