Merge pull request #905 from cmu-delphi/sgratzl/fix_typo

fix: correlation table lag rendering
cmu-delphi · Apr 15, 2021 · d2c818b · d2c818b
2 parents f8a2795 + c93a18a
commit d2c818b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/data/correlation.js b/src/data/correlation.js
@@ -79,7 +79,7 @@ function generateLags(a, b) {
     const bLag = b.slice(lag - i, b.length - i);
     const bValuesLag = bValues.slice(lag - i, b.length - i);
     const model = linear(zip(aWindowValues, bValuesLag));
-    lags.push(asLag(-i, model, aWindow, bLag));
+    lags.push(asLag(i === 0 ? 0 : -i, model, aWindow, bLag));
   }
 
   for (let i = 1; i <= lag; i++) {

diff --git a/src/data/correlationUtils.js b/src/data/correlationUtils.js
@@ -4,7 +4,7 @@
  * @returns string
  */
 export function lagToOffset(lag, wrapped = true) {
-  const wrap = wrapped ? (v) => ` (${v})` : (v) => ` ${v}`;
+  const wrap = wrapped === 'zero' ? String : wrapped ? (v) => ` (${v})` : (v) => ` ${v}`;
   if (lag === 1) {
     return wrap('1 day later');
   }
@@ -17,5 +17,8 @@ export function lagToOffset(lag, wrapped = true) {
   if (lag < -1) {
     return wrap(`${-lag} days earlier`);
   }
+  if (wrapped === 'zero') {
+    return '0 days';
+  }
   return '';
 }