-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi region/indicator time series #1136
base: dev
Are you sure you want to change the base?
Conversation
✔️ Preview link ready! 🔨 Explore the source changes: 832ac51 🔍 Inspect the deploy log: https://app.netlify.com/sites/cmu-delphi-covidcast/deploys/61e6d2012b78a1000744afd0 😎 Browse the preview: https://deploy-preview-1136--cmu-delphi-covidcast.netlify.app |
Thanks for tagging me, I had somehow not seen this when it first arrived. I think it's a great addition and will be very useful. My thoughts below. Main comment: it seems like we are limiting ourselves to 2 curves on either the multi-indicator or multi-region views (I tried selecting more than 2 but only 2 show up). I would like to allow 3 or more in both multi-indicator and multi-region modes. Let me explain.
Minor comment (unrelated to his PR, but it bugs me especially in the context of multiple signals): I would like us to remove "Rescale Y-Axis" radio button in general, because I think it's seldomly used (it doesn't appear anywhere else on our dashboards) and in the multi-signal context I find it confusing. I would expect rescaling to mean something else here. |
closes #1113
Prerequisites:
dev
branchdev
Summary
two new widgets for the dashboard builder: multi region and multi indicator time series:
depending on the selection it will be a single or dual axis: