Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted dashboard cleanup tasks #1234

Closed
wants to merge 1 commit into from
+12 −28
Closed

Assorted dashboard cleanup tasks #1234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/data/meta.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ export class MetaDataManager {
return this.getSensor({ id: 'jhu-csse', signal: 'confirmed_7dav_incidence_prop' });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the JHU signal we are removing... Doesnt that mean we can get rid of this method too?

}
getDefaultDeathSignal(): Sensor | null {
return this.getSensor({ id: 'jhu-csse', signal: 'deaths_7dav_incidence_prop' });
return this.getSensor({ id: 'nchs-mortality', signal: 'deaths_covid_incidence_prop' });
}
Comment on lines 197 to 199
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are getting rid of getDefaultCasesSignal() above, we should get rid of this one too. They dont appear to still be used anywhere.


getSensorsOfType(type: SignalCategory): Sensor[] {
Expand Down
12 changes: 4 additions & 8 deletions src/modes/summary/Summary.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<script>
import IndicatorTable from './IndicatorTable.svelte';
import Overview from './Overview.svelte';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean we can remove src/modes/summary/Overview.svelte? Does that then mean we can remove defaultCasesSensor and defaultDeathSensor from src/stores/index.ts? Perhaps even move defaultHospitalSensor into this file?

import { countyInfo, nationInfo, stateInfo } from '../../data/regions';
import RegionDatePicker from '../../components/RegionDatePicker.svelte';
import {
Expand Down Expand Up @@ -69,18 +68,15 @@
</RegionDatePicker>
<div class="uk-container content-grid">
<div class="grid-3-11">
<FancyHeader invert>{region.displayName}</FancyHeader>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we leave the region name in there for consistency, perhaps followed by an <hr />? This will appear in the "Location" view of this page, after all.

<Overview {date} {region} {fetcher} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the Overview element also means we lose the nested element for IndicatorWarning, which provides helpful information in the case that there is a data lapse. Can we re-add that?

<hr />
<FancyHeader invert sub="Map" anchor="map">{HOSPITAL_ADMISSION.name}</FancyHeader>
<p>{@html HOSPITAL_ADMISSION.signalTooltip}</p>
<RegionMapWrapper {region} {date} sensor={HOSPITAL_ADMISSION} {fetcher} />
<hr />
<FancyHeader invert sub="Chart" anchor="chart">{HOSPITAL_ADMISSION.name}</FancyHeader>
<div class="chart-300">
<HistoryLineChart sensor={HOSPITAL_ADMISSION} {date} {region} {fetcher} />
</div>
<hr />
<FancyHeader invert sub="Map" anchor="map">{HOSPITAL_ADMISSION.name}</FancyHeader>
<p>{@html HOSPITAL_ADMISSION.signalTooltip}</p>
<RegionMapWrapper {region} {date} sensor={HOSPITAL_ADMISSION} {fetcher} />
<hr />
<IndicatorTable {date} {region} {fetcher} />
</div>
</div>
Expand Down
20 changes: 4 additions & 16 deletions src/stores/descriptions.raw.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,18 +43,6 @@ SignalTooltip: Percentage of daily doctor visits that are due to lab-confirmed i

Description: Delphi receives aggregated statistics from Change Healthcare, Inc. on lab-confirmed influenza outpatient doctor visits, derived from ICD codes found in insurance claims. Using this data, we estimate the percentage of daily doctor’s visits in each area that resulted in a diagnosis of influenza. Note that these estimates are based only on visits by patients whose insurance claims are accessible to Change Healthcare.
---
Name: COVID Cases
Id: jhu-csse
Signal: confirmed_7dav_incidence_prop
Highlight: [default]
ExtendedColorScale: true


SignalTooltip: Newly reported COVID-19 cases per 100,000 people, based on data from Johns Hopkins University


Description: This data shows the number of COVID-19 confirmed cases newly reported each day. It reflects only cases reported by state and local health authorities. It is based on case counts compiled and made public by [a team at Johns Hopkins University](https://systems.jhu.edu/research/public-health/ncov/). The signal may not be directly comparable across regions with vastly different testing capacity or reporting criteria.
---
Name: COVID Hospital Admissions
Id: hhs
Signal: confirmed_admissions_covid_1d_prop_7dav
Expand Down Expand Up @@ -89,11 +77,11 @@ SignalTooltip: Confirmed influenza hospital admissions per 100,000 people
Description: This data shows the number of hospital admissions with lab-confirmed influenza each day. We source this data from the Report on Patient Impact and Hospital Capacity published by the US Department of Health & Human Services (HHS).
---
Name: COVID Deaths
Id: jhu-csse
Signal: deaths_7dav_incidence_prop
Id: nchs-mortality
Signal: deaths_covid_incidence_prop


SignalTooltip: Newly reported COVID-19 deaths per 100,000 people, based on data from Johns Hopkins University
SignalTooltip: Newly reported COVID-19 deaths per 100,000 people, based on NCHS mortality data.


Description: This data shows the number of COVID-19 deaths newly reported each day. The signal is based on COVID-19 death counts compiled and made public by [a team at Johns Hopkins University](https://systems.jhu.edu/research/public-health/ncov/).
Description: This data source of national provisional death counts is based on death certificate data received and coded by the National Center for Health Statistics (NCHS). This data is different from the death data available from USAFacts and JHU CSSE. Deaths are reported by the date they occur, not the date they are reported by local health departments, and data is frequently reissued as additional death certificates from recent weeks are received and tabulated.
2 changes: 1 addition & 1 deletion src/stores/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ export const defaultHospitalSensor = derived(sensorList, (sensorList) => {
return sensorList.find((d) => d.signal === 'confirmed_admissions_covid_1d_prop_7dav');
});
export const defaultDeathSensor = derived(sensorList, (sensorList) => {
return sensorList.find((d) => d.signal === 'deaths_7dav_incidence_prop');
return sensorList.find((d) => d.signal === 'deaths_covid_incidence_prop');
Comment on lines 117 to +118
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we can remove this (and one or two above it); see comment in src/modes/summary/Summary.svelte

});

export const currentSensorEntry = derived(
Expand Down
Loading