Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard signals update #1264

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Dashboard signals update #1264

merged 2 commits into from
Dec 5, 2024

Conversation

melange396
Copy link
Contributor

This brings the COVIDcast dashboard signals up to date by removing inactive signals and adding newer ones...

  • CHANGED:
    • hhs : confirmed_admissions_covid_1d_prop_7dav --> hospital-admissions : smoothed_adj_covid19_from_claims
  • REMOVED:
    • hhs : confirmed_admissions_influenza_1d_prop_7dav
    • chng : smoothed_adj_outpatient_flu
  • ADDED:
    • google-symptoms : s01_smoothed_search
    • google-symptoms : s03_smoothed_search
    • google-symptoms : s04_smoothed_search
    • nssp : pct_ed_visits_covid
    • nssp : pct_ed_visits_influenza

Copy link

netlify bot commented Nov 25, 2024

Preview link ready!

Name Link
🔨 Latest commit d68c1e8
🔍 Latest deploy log https://app.netlify.com/sites/cmu-delphi-covidcast/deploys/674f7d87fefbb60008d11d50
😎 Deploy Preview https://deploy-preview-1264--cmu-delphi-covidcast.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@melange396
Copy link
Contributor Author

see a preview of this change at: https://deploy-preview-1264--cmu-delphi-covidcast.netlify.app/
and compare with the live version: https://delphi.cmu.edu/covidcast/

@melange396
Copy link
Contributor Author

NOTE: this change should be followed by updates to related and long-neglected documentation at:
https://github.com/cmu-delphi/delphi-epidata/blob/17ce59ddf903856cb0b7190fc494dee03a84fa3a/docs/api/covidcast_signals.md?plain=1#L26-L41

whoops, based this branch off of an old state of the dev branch
Copy link

@biganemone biganemone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a dramatic improvement, and the state of things was so bad before that I say we just move ahead with it based on it looking and feeling more credible. @carlynvandyke is likely to be leading a larger QA effort with Tina's help soonish, which may dig more into details.

@melange396 melange396 merged commit 04ffbab into dev Dec 5, 2024
6 checks passed
@melange396 melange396 deleted the dashboard_signal_update_nov2024 branch December 5, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants