-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API key field to covidcast imports #55
Conversation
@melange396 also fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works, but it doesnt do its verification until the focus is moved off of the input field, and it doesnt repopulate the metadata until verified... The delay can be confusing and will be frustrating, unless perhaps we include a "working" indicator or similar. Did you explore triggering the key verification on typing (the on:input
event instead of on:change
)?
I moved the key verification to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment. Otherwise, the oninput w/ delayed request looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #47: