Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate micromamba setup action #1024

Merged
merged 5 commits into from
Sep 30, 2024
Merged

Migrate micromamba setup action #1024

merged 5 commits into from
Sep 30, 2024

Conversation

minhkhul
Copy link
Contributor

This PR might fix this problem thst's blocking blog build:

Warning: This action is deprecated and no longer maintained. Please use mamba-org/setup-micromamba instead. See [https://github.com/mamba-org/provision-with-micromamba#migration-to-setup-micromamba](https://github.com/mamba-org/provision-with-micromamba#migration-to-setup-micromamba%60) for a migration guide.

Copy link

netlify bot commented Sep 25, 2024

Deploy Preview for cmu-delphi-main ready!

Name Link
🔨 Latest commit a764d33
🔍 Latest deploy log https://app.netlify.com/sites/cmu-delphi-main/deploys/66faae018af9b0000809e90b
😎 Deploy Preview https://deploy-preview-1024--cmu-delphi-main.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@minhkhul minhkhul marked this pull request as draft September 25, 2024 19:53
@minhkhul
Copy link
Contributor Author

minhkhul commented Sep 25, 2024

Build time Set up step is 50 minutes with this new setup action (vs max 5 mins before). Will check for alternative way to go about this before settling.

@melange396
Copy link
Contributor

looks like it worked but it took a loooong time -- almost 2h!!! https://github.com/cmu-delphi/www-main/actions/runs/11039802772/job/30666229264

i ran it again to see if its a fluke or if it will pick up cache from the prior run: https://github.com/cmu-delphi/www-main/actions/runs/11041452519/job/30671730241

@melange396
Copy link
Contributor

@minhkhul looks like our messages crossed in the night! This action was running fairly regularly at around 13 minutes with occasional excursions... Either way, its a large departure from before, but we should wait and see what happens with the second run.

@melange396
Copy link
Contributor

The second run did not have appreciable time savings. 1.5-2h is an incredibly long time to wait for this, we should see what else we can do to speed it up. The "Create environment" step has a lot of output that looks similar to the "Run mamba-org/setup-micromamba@v1" step, perhaps there is some repetition that can be removed? That is probably not enough though -- even half the runtime is still much longer than the job used to take.

@minhkhul
Copy link
Contributor Author

ye I've been looking into other options for building the blog today. I'll close this one for now.

@minhkhul minhkhul closed this Sep 27, 2024
@minhkhul minhkhul reopened this Sep 27, 2024
@minhkhul minhkhul marked this pull request as ready for review September 30, 2024 13:55
@minhkhul
Copy link
Contributor Author

Added caching, which is working, bringing it down to 4 min. https://github.com/cmu-delphi/www-main/actions/runs/11096551953/job/30830681257

Copy link
Contributor

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@melange396 melange396 merged commit b972605 into dev Sep 30, 2024
8 checks passed
@melange396 melange396 deleted the migrate-micromamba-action branch September 30, 2024 14:24
@melange396 melange396 mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants