Temporarily deactivate French page #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lianmakesthings <[email protected]>
lianmakesthings
requested review from
AloisReitbauer,
thschue,
joshgav,
kgamanji and
angellk
as code owners
✅ Deploy Preview for tag-app-delivery ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This is a very exciting improvement to the repo, though I appreciate it may be confusing / frustrating for you @mathieu-benoit and @guillermotti who helped with the original PR (#601). Absolutely looking forward to seeing French in as soon as we can get that glossary (or whatever doc you choose) translated. Thanks again for your hard work on the original PR and looking forward to this process being easier for you moving forward! |
abangser
approved these changes
Apr 17, 2024
|
Thanks @abangser and @lianmakesthings, totally makes sense indeed, thanks for this simplification/automation around this! JFYI: the French translation will be re-enabled with the first translation of the Glossary there: #693. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new language support flow we now require that each language not only is configured in
website/config.tomlbut also has a corresponding folder inwebsite/content/. Otherwise the page will remain empty.To reduce confusion, I've disabled French in the config for now until the community has translated at least one key page so the script can do its thing and duplicate the other pages from English.
cc @abangser @mathieu-benoit