-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starting a repo with basic python code best practices #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a thought about including something about custom loggers. Not sure if this is already planned, but we might consider adding a pyproject.toml
to this repository as an example. This seems very useful for beginning projects though! Good idea.
see #3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for a first pass.
It would probably be good to include a reference to PEP8 styling and auto-formatters |
See #8. I was thinking of tackling this as a separate PR. |
|
||
### Variable naming | ||
* Generally, choose nouns for variables and verbs for methods | ||
* Clear variable and method names can reduce the need for comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is mentioning snake case appropriate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the list could grow - see our previous discussion about where to put this. I put a few examples, but let's discuss where to keep more details. This PR doesn't have to depend on it - we can make additions/changes later.
What's the plan for merging this? Are you thinking after tomorrow's meeting maybe? This is self-serving as I want to merge #11 by early next week. |
I'd be happy to see it merged before tomorrow's meeting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. The responsibility of who merges is group specific; I appreciate setting clear rules on that.
This PR is not complete but provides a good starting point for many projects today.
Closes #2, Closes #4, Closes #5, Closes #6, Closes #7