Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting a repo with basic python code best practices #1

Merged
merged 11 commits into from
Jul 19, 2024

Conversation

gonuke
Copy link
Member

@gonuke gonuke commented Jul 16, 2024

This PR is not complete but provides a good starting point for many projects today.

Closes #2, Closes #4, Closes #5, Closes #6, Closes #7

Copy link

@connoramoreno connoramoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a thought about including something about custom loggers. Not sure if this is already planned, but we might consider adding a pyproject.toml to this repository as an example. This seems very useful for beginning projects though! Good idea.

do_task.py Show resolved Hide resolved
@gonuke
Copy link
Member Author

gonuke commented Jul 17, 2024

Added a thought about including something about custom loggers. Not sure if this is already planned, but we might consider adding a pyproject.toml to this repository as an example. This seems very useful for beginning projects though! Good idea.

see #3

Copy link
Contributor

@MicahGale MicahGale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like hyperlinks.

Side note: only gitlab supports Closes #1, #2, ... GitHub you have to do: closes #1, closes #2...

I fixed that for you.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
do_task.py Outdated Show resolved Hide resolved
Copy link
Contributor

@MicahGale MicahGale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for a first pass.

@connoramoreno
Copy link

connoramoreno commented Jul 17, 2024

It would probably be good to include a reference to PEP8 styling and auto-formatters

@MicahGale
Copy link
Contributor

It would probably be good to include a reference to PEP8 styling and auto-formatters

See #8. I was thinking of tackling this as a separate PR.

MicahGale added a commit that referenced this pull request Jul 17, 2024
MicahGale added a commit that referenced this pull request Jul 17, 2024

### Variable naming
* Generally, choose nouns for variables and verbs for methods
* Clear variable and method names can reduce the need for comments
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is mentioning snake case appropriate?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the list could grow - see our previous discussion about where to put this. I put a few examples, but let's discuss where to keep more details. This PR doesn't have to depend on it - we can make additions/changes later.

@MicahGale
Copy link
Contributor

What's the plan for merging this? Are you thinking after tomorrow's meeting maybe? This is self-serving as I want to merge #11 by early next week.

@gonuke
Copy link
Member Author

gonuke commented Jul 18, 2024

What's the plan for merging this? Are you thinking after tomorrow's meeting maybe? This is self-serving as I want to merge #11 by early next week.

I'd be happy to see it merged before tomorrow's meeting

Copy link
Contributor

@MicahGale MicahGale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. The responsibility of who merges is group specific; I appreciate setting clear rules on that.

@MicahGale MicahGale merged commit 06a5214 into cnerg:main Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants