adding sort shortest to longest and vice versa #41
+162
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonuke
requested changes
Feb 6, 2022
There was a problem hiding this comment.
This is reasonably straightforward - but one philosophical question: Could you instead check for invalid pathways upon creation of a list of pathways? I guess that might not make sense because you can't control where a list of pathways comes from, but you could check for invalid pathways in the lists you do generate. Or do those still represent useful information in some instances?
| {(5.3)}]) | ||
| def test_check_for_invalid_pathways_type_error(pathways): | ||
| with pytest.raises(TypeError) as excinfo: | ||
| obj = pa.sort_by_longest(pathways) |
There was a problem hiding this comment.
why not just call check_for_invalid_pathways here?
Comment on lines
+601
to
+602
| obs = pa.check_for_invalid_pathways(pathways) | ||
| assert obs is None |
There was a problem hiding this comment.
Does it make more sense to some how test that there is no exception?
|
Not sure if this is a priority @nuclearkatie , but it would be nice to clear this up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pathway_analysis(coveralls)pathway_analysisand tests