Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass SONARQUBE_* to sonarqube #59

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

gbonnefille
Copy link
Contributor

@gbonnefille gbonnefille commented Oct 9, 2020

Proposed changes

Pass the SONARQUBE_* var env to underlying process.
These var env are mandatory and thus override the configuration file options.

Types of changes

What types of changes does your code introduce to this project?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Issues closed by changes

List here all issues closed by your changes. Use a list of items like - [x] Close #0

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I agree with the CODE OF CONDUCT
  • Lint and unit tests pass locally with my changes
  • Codacy validates the quality of the modifications
  • GitHub Actions CI workflow passes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@gbonnefille
Copy link
Contributor Author

A similar issue was reported, patched and accepted upstream: SonarSource/docker-sonarqube#435

@begarco begarco added this to the 2.3.0 milestone Oct 19, 2020
@diegorodriguez31 diegorodriguez31 modified the milestones: 3.0.0, 3.1.0 Aug 23, 2023
@Topin2001 Topin2001 removed this from the 3.1.0 milestone Dec 14, 2023
Copy link

sonarcloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SONARQUBE_JDBC_* var env ignored
4 participants