Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add App deployment configuration #207

Closed
wants to merge 1 commit into from

Conversation

bowlerct
Copy link
Contributor

@bowlerct bowlerct commented Jan 7, 2024

Issue #76

  • Add deployment configuration file
  • Add logged in server to NavBar above version
  • Modify login to allow selection of urls from deployment configuration file
  • Default project is Cobbler so updated README to include --project is required for ng generate

@github-actions github-actions bot added the Frontend Project cobbler-frontend label Jan 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f57e46e) 25.80% compared to head (beb0f11) 15.13%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #207       +/-   ##
===========================================
- Coverage   25.80%   15.13%   -10.67%     
===========================================
  Files          45        7       -38     
  Lines        1461     1189      -272     
  Branches      437      423       -14     
===========================================
- Hits          377      180      -197     
+ Misses       1064      990       -74     
+ Partials       20       19        -1     
Flag Coverage Δ
unit-cobbler-api 4.44% <ø> (ø)
unit-cobbler-frontend ?
unit-typescript-xmlrpc 61.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchoolGuy SchoolGuy self-requested a review January 7, 2024 10:49
@SchoolGuy SchoolGuy added this to the V0.0.1 milestone Jan 7, 2024
Copy link
Member

@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I see that it is WIP but I think this is already at a great level of quality.

In my eyes the tests should be made green and the server field can be made invisible in case only one URL is present in the optional config file. After that we can already merge this PR!

@SchoolGuy
Copy link
Member

@bowlerct the project was updated to Angular 17. Furthermore, a few things have been reorganized. If you are interested in continuing this PR I would recommend to rebase it before that.

@SchoolGuy
Copy link
Member

I have decided due to a lack of response on this PR that I will adopt it. Since the codebase changed drastically, I will close it and open a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Project cobbler-frontend
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants