Add safari driver #1220
Add safari driver #1220
Conversation
Andmedoctopus
force-pushed
the
master
branch
3 times, most recently
from
31a78c1 to
f1cdc99
Compare
Andmedoctopus
force-pushed
the
master
branch
2 times, most recently
from
13e901e to
623cfcc
Compare
Andmedoctopus
force-pushed
the
master
branch
2 times, most recently
from
6f04c51 to
ac85e3a
Compare
|
@fsouza Please take a look. CI almost stable |
Andmedoctopus
force-pushed
the
master
branch
from
6737d17 to
4c7d84a
Compare
Andmedoctopus
force-pushed
the
master
branch
from
8041321 to
465cea3
Compare
Andmedoctopus
force-pushed
the
master
branch
from
87090e2 to
5b521ba
Compare
Andmedoctopus
force-pushed
the
master
branch
from
5b521ba to
e741974
Compare
|
@fsouza CI is green, please take a look after holidays ☃️ 🙂 |
.github/workflows/main.yml
Outdated
| @@ -20,6 +20,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
|
|
|||
| strategy: | |||
| max-parallel: 3 | |||
There was a problem hiding this comment.
curious on why we're making this change?
There was a problem hiding this comment.
CI was unstable. Removed all limitation. Works ok
tests/click_elements.py
Outdated
|
|
||
|
|
||
| class ClickElementsTest: | ||
| def test_click_links(self): | ||
| self.browser.links.find_by_text("FOO").click() | ||
| self.assertIn("BAR!", self.browser.html) | ||
| self.browser.visit(EXAMPLE_APP) |
There was a problem hiding this comment.
why did we need to make this change?
There was a problem hiding this comment.
The visit in setUp was unstable for some reason and page just stuck. Now seems ok. Removed all visit in tests
tests/test_webdriver_remote.py
Outdated
| def test_should_be_able_to_change_user_agent(self): | ||
| "Remote should not support custom user agent" | ||
| pass |
There was a problem hiding this comment.
can we explicitly skip it with a message?
Andmedoctopus
force-pushed
the
master
branch
from
e581276 to
6e077e5
Compare
|
@fsouza I have fixed all remarks. Could you take a look, please? |
|
@fsouza could you take a look to the PR, please? |
There was a problem hiding this comment.
@Andmedoctopus thanks for the ping, sorry I somehow missed the earlier notification. This looks good, thanks for contributing!
|
@fsouza thank you! Could you release a new version of splinter, please? |
|
Will tag a new release once #1229 passes. |
No description provided.