Merge #134441

134441: storage: disable multilevel compactions r=jbowens a=itsbilal In their current state, multilevel compactions can cause momentary spikes in L0 sublevels, resulting in undesirable side-effects elsewhere. Fixes #134423. Epic: none Release note: None Co-authored-by: Bilal Akhtar <[email protected]>
cockroachdb · Nov 6, 2024 · 4dce850 · 4dce850
2 parents 2c3fc8e + 88a7276
commit 4dce850
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/pkg/storage/pebble.go b/pkg/storage/pebble.go
@@ -891,6 +891,10 @@ func DefaultPebbleOptions() *pebble.Options {
 		Lower: EncodeMVCCKey(MVCCKey{Key: keys.LocalRangeLockTablePrefix}),
 		Upper: EncodeMVCCKey(MVCCKey{Key: keys.LocalRangeLockTablePrefix.PrefixEnd()}),
 	}
+	// Disable multi-level compaction heuristic for now. See #134423
+	// for why this was disabled, and what needs to be changed to reenable it.
+	// This issue tracks re-enablement: https://github.com/cockroachdb/pebble/issues/4139
+	opts.Experimental.MultiLevelCompactionHeuristic = pebble.NoMultiLevel{}
 
 	for i := 0; i < len(opts.Levels); i++ {
 		l := &opts.Levels[i]