Skip to content

Commit

Permalink
sql: skip a couple of tests under deadlock
Browse files Browse the repository at this point in the history
`TestExplainRedact` and `TestExplainRedactDDL` are quite long, making
that some KV level deadlock mechanism fires incorrectly. We've skipped
other tests due to this, so this commit skips these two as well.

Release note: None
  • Loading branch information
yuzefovich committed Dec 12, 2023
1 parent e243152 commit dbcaee8
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 0 deletions.
1 change: 1 addition & 0 deletions pkg/ccl/testccl/sqlccl/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ go_test(
"//pkg/sql/tests",
"//pkg/testutils",
"//pkg/testutils/serverutils",
"//pkg/testutils/skip",
"//pkg/testutils/sqlutils",
"//pkg/testutils/testcluster",
"//pkg/util/hlc",
Expand Down
3 changes: 3 additions & 0 deletions pkg/ccl/testccl/sqlccl/explain_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import (
"github.com/cockroachdb/cockroach/pkg/sql/lexbase"
"github.com/cockroachdb/cockroach/pkg/sql/tests"
"github.com/cockroachdb/cockroach/pkg/testutils/serverutils"
"github.com/cockroachdb/cockroach/pkg/testutils/skip"
"github.com/cockroachdb/cockroach/pkg/util/leaktest"
"github.com/cockroachdb/cockroach/pkg/util/log"
"github.com/cockroachdb/cockroach/pkg/util/randutil"
Expand All @@ -33,6 +34,8 @@ func TestExplainRedactDDL(t *testing.T) {
defer leaktest.AfterTest(t)()
defer log.Scope(t).Close(t)

skip.UnderDeadlock(t, "the test is too slow")

const numStatements = 10

ctx := context.Background()
Expand Down
2 changes: 2 additions & 0 deletions pkg/sql/explain_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -509,6 +509,8 @@ func TestExplainRedact(t *testing.T) {
defer leaktest.AfterTest(t)()
defer log.Scope(t).Close(t)

skip.UnderDeadlock(t, "the test is too slow")

const numStatements = 10

ctx := context.Background()
Expand Down

0 comments on commit dbcaee8

Please sign in to comment.