teamcity-trigger: ensure that race tag is only passed once
#110309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By running under `-race`, the go command defines the `race` build tag for us [1]. Previously, we defined it under `TAGS` to let the issue poster know that this is a failure under `race` and indicate that in the issue. At the time, defining the tag twice didn't cause issues but after cockroachdb#109773, it led to build failures [2]. To reproduce locally: ``` bazel test -s --config=race pkg/util/ctxgroup:all --test_env=GOTRACEBACK=all --define gotags=bazel,gss,race ``` As a follow-up, we should find another way to let the issue poster know that a failure was running under `race`. [1] https://go.dev/doc/articles/race_detector#Excluding_Tests [2] cockroachdb#109994 (comment) Epic: none Release note: None
|
This change is |
renatolabs
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @srosenberg)
rickystewart
approved these changes
Sep 11, 2023
Closed
|
bors r+ |
|
Build succeeded: |
Closed
Closed
This was referenced Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By running under
-race, the go command defines theracebuild tag for us [1].Previously, we defined it under
TAGSto let the issue poster know that this is a failure underraceand indicate that in the issue.At the time, defining the tag twice didn't cause issues but after #109773, it led to build failures [2].
To reproduce locally:
As a follow-up, we should find another way to let the issue poster know that a failure was running under
race.[1] https://go.dev/doc/articles/race_detector#Excluding_Tests
[2] #109994 (comment)
Epic: none
Release note: None