Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CompressionLevel and make v2 Kafka sink default #19169

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kathancox
Copy link
Contributor

@kathancox kathancox commented Nov 21, 2024

Fixes DOC-11339, DOC-10867, DOC-10830, DOC-10700

This PR:

  • Updates the kafka_sink_config option with the CompressionLevel field in v24.3.
  • Removes the note for the cluster setting to enable the v2 Kafka sink, because this is the default in v24.3.
  • Adds the cluster setting changefeed.sink-io-workers under Kafka for the default v2 sink.

Rendered Preview

https://deploy-preview-19169--cockroachdb-docs.netlify.app/docs/v24.3/changefeed-sinks.html#kafka-sink-configuration

Copy link

Files changed:

Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit de9c4ec
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/673fa4bbd57dbf0008b0e34c

Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit de9c4ec
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/673fa4bb440c470008119d6b

Copy link

netlify bot commented Nov 21, 2024

Netlify Preview

Name Link
🔨 Latest commit de9c4ec
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/673fa4bb084dbf0008b46722
😎 Deploy Preview https://deploy-preview-19169--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kathancox kathancox marked this pull request as ready for review November 21, 2024 21:26
The `kafka_sink_config` option allows configuration of a changefeed's message delivery, Kafka server version, and batching parameters.
You can configure flushing, acknowledgments, compression, and concurrency behavior of changefeeds running to a Kafka sink with the following:

- Set the [`changefeed.sink_io_workers` cluster setting]({% link {{ page.version.version }}/cluster-settings.md %}#setting-changefeed-sink-io-workers) to configure the number of concurrent workers used by changefeeds in the cluster when sending requests to a Kafka sink. When you set `changefeed.sink_io_workers`, it will not affect running changefeeds; [pause the changefeed]({% link {{ page.version.version }}/pause-job.md %}), set `changefeed.sink_io_workers`, and then [resume the changefeed]({% link {{ page.version.version }}/resume-job.md %}). Note that this cluster setting will also affect changefeeds running to [Google Cloud Pub/Sub](#google-cloud-pub-sub) sinks and [webhook sinks](#webhook-sink).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to add this now that the v2 Kafka sink is the default? (This paragraph is included for Pub/Sub + Webhook too.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant