Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Artifact action to v4 #1076

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Artifact action to v4 #1076

wants to merge 1 commit into from

Conversation

rail
Copy link
Member

@rail rail commented Nov 20, 2024

Fixes: DEVINF-1334


This change is Reviewable

Fixes: DEVINF-1334
@rail rail self-assigned this Nov 20, 2024
@rail rail requested a review from jlinder November 20, 2024 01:41
@rail rail enabled auto-merge November 20, 2024 13:45
@rail rail requested a review from bobvawter November 20, 2024 13:57
@bobvawter
Copy link
Contributor

Tests don't pass.

@rail
Copy link
Member Author

rail commented Nov 20, 2024

Tests don't pass.

Ooooh, looks like they changed the action behavior.

@rail
Copy link
Member Author

rail commented Nov 20, 2024

Looks like the name should be unique. We need to append something using ${{ matrix.xxx }}. Any suggestions?

@Jeremyyang920
Copy link

Looks like the name should be unique. We need to append something using ${{ matrix.xxx }}. Any suggestions?

I don't have a real suggestion, Maybe whatever the source DB was but not sure if that ends up being unique right now. cc @ryanluu12345

@rail
Copy link
Member Author

rail commented Nov 22, 2024

Hmm, actually this may be a bit more complicated. The download step should collect all uploaded artifacts. 🤔

@ryanluu12345
Copy link
Contributor

Hmm, actually this may be a bit more complicated. The download step should collect all uploaded artifacts. 🤔

Hi @rail , my apologies for the late reply here. I have some work this week that entails updating our CI for replicator. I'll look into making these changes so that we collect all uploaded artifacts together.

@rail
Copy link
Member Author

rail commented Nov 26, 2024

No pressure, it's just at some point in December the old version is going to stop working. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants