Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contextual component for using individual Stripe elements #64

Merged
merged 4 commits into from
Sep 3, 2019

Conversation

lindyhopchris
Copy link
Contributor

Adds a contextual component called {{stripe-elements}}. This is useful if you want to set options on the Stripe elements object:

{{#stripe-elements options=elementOptions as |elements|}}
  {{elements.card options=cardOptions}}
{{/stripe-elements}}

Or if creating your own form, where all the individual Stripe elements need to be created from the same Stripe elements object:

{{#stripe-elements as |elements|}}
  {{elements.cardNumber}}
  {{elements.cardExpiry}}
  {{elements.cardCvc}}
  {{elements.postalCode}}
{{/stripe-elements}}

Closes #49 #33

@lindyhopchris lindyhopchris requested a review from st-h August 10, 2019 14:07
@lindyhopchris
Copy link
Contributor Author

@st-h any chance you're able to review this and merge it if it looks ok?

@st-h
Copy link
Contributor

st-h commented Sep 3, 2019

@lindyhopchris just fixed some minor typos in the readme. Otherwise I think this looks good. However, I currently have way less time to deal with stripe stuff as I would like to. And I am still running on my fork, but I will have to migrate quite soon, so I will hopefully be able to invest a little more time into this add-on then.

@st-h st-h merged commit 1e0be18 into develop Sep 3, 2019
@lindyhopchris
Copy link
Contributor Author

@st-h thanks for looking at this.

I'm also really pushed for time at the moment, so totally understand. I do however want to get this library sorted out, because it's such an important bit of functionality. Would therefore be good to coordinate our efforts... so when that bit of time comes up for you, let me know and we can work collaboratively on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a contextual component for sharing elements between stripe-card-* elements
2 participants