wrap error code in Ember.Error on reject #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build is breaking, can you please check? |
|
just re-ran build and noticed its failing too, weird https://travis-ci.org/ride/ember-stripe-service/builds. I'll double check |
|
I just rebuilt this and the test that check rejections fails, if you're still interested in making this happen, would you mind updating the tests so we can get it in? Otherwise, would you mind closing the PR? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap errors from Stripe in
Ember.Error. We want to be able to write tests for handling errors for Stripe. If we just reject with the error object then our tests we always fail. So instead we need to wrap the test in an Ember.Error object.Fixes #30 See the discussion in that issue.