-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support 'auth when you only have CLI' once again #6
Draft
snickell
wants to merge
22
commits into
main
Choose a base branch
from
cli-only-auth
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snickell
commented
Aug 1, 2023
•
edited
Loading
edited
- We used to have the ability to auth with Google OAuth "out of band" from CLI-only setups like remote ssh or docker containers. ood=>out of band=>generated url can be opened on another computer's browser=>if you only have CLI you need this). No special HTTPS server running on same localhost as the web browser was required.
- Google sunset "oob" support last year (reason: used in phishing scams): https://developers.google.com/identity/protocols/oauth2/resources/oob-migration
- The closest we can come (intentionally on GOOGs security part) requires adding an additional step: a port forward between the desktop computer running Chrome and the server/container running the aws-google instance. This is easily setup in docker-compose or skaffold+k8s situations, but its harder to setup if roll your own (you could use ssh port forwarding).
- The UX is basically the same for the end user, but the caller of aws-google (outside this library's black box) will have to solve the problem of making the cli-only aws-google server available on a local port on the browser desktop computer).
Google sunset "oob" support last year breaking cli auth: https://developers.google.com/identity/protocols/oauth2/resources/oob-migration
revert rakefile changes
add final newline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.