Update gem dependencies #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revert rakefile changes
add final newline
cat5inthecradle
commented
Oct 3, 2024
cat5inthecradle
commented
Oct 3, 2024
snickell
approved these changes
Oct 3, 2024
unlox775-code-dot-org
approved these changes
Oct 11, 2024
cat5inthecradle
commented
Oct 22, 2024
| @@ -108,6 +108,7 @@ | |||
| expiration = provider.expiration | |||
| _(expiration).must_equal(provider.expiration) | |||
| Timecop.travel(1.5.hours.from_now) do | |||
| provider.refresh! | |||
There was a problem hiding this comment.
@Hamms The newer versions of aws-sdk-core do not automatically refresh when you check the expiration property, so this test no longer triggers a refresh. I've added an explicit call to refresh on our provider, so what we're testing here is the handling of expired tokens in our google.rb refresh method.
| } | ||
|
|
||
| # Use the AWS CLI to set the credentials in the session profile | ||
| credentials_map.each do |key, value| | ||
| system("aws configure set #{key} #{value} --profile #{@session_profile}") |
There was a problem hiding this comment.
Not an issue with your current code changes, just a vulnerability in general. This putting secrets on CLI arguments allows other people to sniff the creds with a simple ps auxw. This is a recommendation by ChatGPT for an alternate (untested). Should I add this as a separate PR?
require 'aws-sdk-core'
def write_credentials
shared_credentials = Aws::SharedCredentials.new(profile_name: @session_profile)
shared_credentials.load
shared_credentials.update(
access_key_id: @credentials.access_key_id,
secret_access_key: @credentials.secret_access_key,
session_token: @credentials.session_token,
expiration: @expiration
)
end
There was a problem hiding this comment.
yeah, sounds like a good idea
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a bit too much, happy to break up if preferred.
Update
aws-sdk-coreThis is why I started this work. We want to update
aws-sdk-autoscalingin the code-dot-org repository, and this was blocking that.Updates other gems to their latest versions compatible with Ruby 3.0.5
Because why not?
A bunch of automatic linting
Prettier was not happy about 6 year old code.
Adds some Docker tooling for developer experience
Added this after struggling with ruby versions and other installed gems on my local workstation. Isolating the development environment while working on the gem was handy
Add a GitHub action to run tests on PR's
My decaf mocha may or may not have been decaf, clearly overreaching here. This runs tests against both the latest Ruby (3.3.x) and the version pinned in code-dot-org (3.0.5)