update dependencies and switch to nextjs links. Moves page into _app!!!! #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slug and title now in getstatic or getserverside props!!!!
oohwooh
reviewed
Mar 17, 2023
|
useTopo is a function you wrap your nextjs config with and it uses webpack to replace the normal topo links (including with as="a" for buttons and boxes) with nextjs compatible ones. this means that you do not have to do anything special to get the links to work, it just happens automagically! |
based on my testing everything seems like it works fine, I'm not super familiar with all of the forms though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
title and slug properties now set in getstaticprops or getserverside props. prevents re-rendering the component every time (this stops duplicate requests for contributors in footer and increases performance).
Also moved moment-timezone out of _app, reduced first load js by about 50kB.
Switching to nextjs compatible links should make pages load faster and makes user experience much smoother!