Support indexed keys of file uploads in file upload normalizer #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing tests seem to be related to a broken minimum dependency about a missing |
|
Guess we need to fix main first then. |
Toflar
approved these changes
Dec 9, 2024
Toflar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Contao does not have a built-in support for "multiple file uploads", our
terminal42/contao-fineuploaderhas added a handler in Contao 5 to convert an array of uploads to separate upload fields. So if you have an input fieldattachementswith fineuploader, you would get anattachements_0,attachements_1etc. property in$filesof Contao'sprocessFormDatahook.This PR normalizes this back to the expected format of normalized files (
attachements => [0 => ..., 1 => ...]).