issue#473 add link to the top page #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要 | About
Fix: #473
ついでに、PC表示時のロゴおよびトップページ表示時のロゴをタップした時にも、トップページに戻る処理を入れました。一般的な挙動かと思いますが、不適当でしたらご指摘ください。
その他、初めてのPRのためご確認よろしくお願いします。
動作確認方法 | How to check
#473 に関しては、スマートフォンで地図ページを表示してロゴをタップする。
追加処理に関しては、それぞれ地図ページ、トップページにてロゴをタップ。
ちなみに、.aside-title-sp / sp_logo.pngがPC用、.aside-title-pc / logo.pngがスマホ用なんですね。歴史的な事情でしょうか。今後のために変えても良いかと思いました。