#459 の動作確認用PR #481
Open
#459 の動作確認用PR #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuiseki
requested changes
Feb 3, 2024
|
@yuiseki masterブランチの内容でテストが実行されてしまっているっぽいですね…… |
|
@munierujp ありがとうございます。これ、Branch Protection の設定の問題ですかね？ |
|
@halsk 自分もあまり詳しくないのですが、どちらかというとGitHub Actionsの設定かもしれません。 GitHub ActionsをCIに使うとき、マージ先のコードでビルトやテストが行われてしまう #GitHub - Qiita @NEKOYASAN #464 でGitHub Actionsのトリガーに |
|
Checksで利用するWorkflowだったので、Actionsをbase branch側のWorkflowを使うことでWorkflowの改ざんと回避を予防する意図がありましたが、@actions/checkout周りの修正を完全に忘れたままMergeしてますね... pull_requestに変えてしまうか@actions/checkoutのrefをhead branchのshaにすることで解消できると思いますが、pull_requestに変えてしまうほうが都合良いですかね？ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要 | About
#459 の動作確認のために、意図的にテストを失敗させるPRをつくります。