Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

多言語対応 #256

Merged
merged 63 commits into from
Mar 19, 2020
Merged

多言語対応 #256

merged 63 commits into from
Mar 19, 2020

Conversation

rayjolt
Copy link

@rayjolt rayjolt commented Mar 14, 2020 •
edited
Loading

📝 関連issue

⛏ 変更内容

  • nuxt-i18nの言語設定に英語を追加
  • 翻訳対象文字列の抽出
  • 言語切り替え実装
  • 内部リンクの多言語対応
  • 英語翻訳

@rayjolt rayjolt changed the base branch from development to develop-i18n March 14, 2020 09:01
@netlify
Copy link

netlify bot commented Mar 14, 2020

Deploy preview for elated-goldwasser-3444a3 ready!

Built with commit 7f6b987

https://deploy-preview-256--elated-goldwasser-3444a3.netlify.com

@Yfuruchin
データ修正
ff85c66 
元のCSVが3/12がダブっていた
道知事ツイッターデータをもとに内容を手動で変更

3/12　76
https://twitter.com/suzukinaomichi/status/1238276027341627392
3/13　73
https://twitter.com/suzukinaomichi/status/1238642722405138433
@Yfuruchin
typo
7ffeb69 
タイポ修正
@rayjolt rayjolt force-pushed the i18n branch 2 times, most recently from ceeaf79 to 7b58ec7 Compare March 15, 2020 11:27
NEKOYASAN and others added 11 commits March 17, 2020 00:21
@NEKOYASAN
Revert "Merge pull request codeforsapporo#271 from Nekoya3/Automatic"
c4e4bc6 
This reverts commit eb0be57, reversing
changes made to 9dab08a.
@NEKOYASAN
Revert "CORS対応"
345adae 
This reverts commit feb8c76.
@NEKOYASAN
Revert "Merge pull request codeforsapporo#268 from Nekoya3/Automatic"
f7ae685 
This reverts commit 6407ced, reversing
changes made to f2413cb.
@NEKOYASAN
Merge pull request codeforsapporo#273 from codeforsapporo/test
751bb25 
Revert 269
@NEKOYASAN
データ更新3/17
2e8f3ef
@NEKOYASAN
Merge pull request codeforsapporo#274 from Nekoya3/development
761f197 
データ更新3/17
@rayjolt
英訳を追加
58397d3
@rayjolt
英訳を修正、抜けた翻訳対象文字列を追加
07d60dc
@rayjolt
言語セレクタを東京サイトから引用
ad0fbee 
Source: https://github.com/tokyo-metropolitan-gov/covid19/blob/2c39aa6bf3a09250286517deed1cbfb122f59b86/components/LanguageSelector.vue
@rayjolt
内部リンクの多言語対応
e3d228a 
言語設定をまもるようにlocalePathでリンクのターゲットを指定する。
@rayjolt
サイトロゴリンクの多言語対応
662db55
@rayjolt rayjolt marked this pull request as ready for review March 17, 2020 15:06
@rayjolt
Copy link
Author

rayjolt commented Mar 17, 2020

陽性患者の属性の所は未翻訳ですが、とりあえず公開するといいと思います！後、HTML要素にlang属性の設定の仕方がわからなかったので、わかっていたら教えてください。（それも後日のPRでいいと思います。）

@rayjolt
Copy link
Author

rayjolt commented Mar 17, 2020

上のDeploy previewリンクが古いのですが、更新できますか？

@NEKOYASAN
Copy link
Member

Deploy Previewさんが仕事してないですね...

@daisuke-fukuda
Copy link

developブランチをプレビュー対象に指定してるからですね。ちょっとお待ちを

@daisuke-fukuda
Copy link

うーん、うまくできないな、、、

draftでdevelopmentにPR送る事って可能ですか？

@NEKOYASAN NEKOYASAN changed the base branch from develop-i18n to development March 18, 2020 05:53
@NEKOYASAN
Copy link
Member

ベースブランチをdevelopmentにいったん変更しました

@NEKOYASAN NEKOYASAN changed the base branch from development to develop-i18n March 19, 2020 04:59
@NEKOYASAN NEKOYASAN merged commit 34c400e into codeforsapporo:develop-i18n Mar 19, 2020
@NEKOYASAN
Copy link
Member

いったんマージして対応します！

@rayjolt rayjolt deleted the i18n branch March 21, 2020 14:52
NEKOYASAN pushed a commit to NEKOYASAN/covid19 that referenced this pull request Jun 21, 2020
@MiyukiShirasawa
Merge pull request codeforsapporo#256 from MiyukiShirasawa/development
7306f19 
data.json更新041202
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

北海道版多言語対応
5 participants
@rayjolt @NEKOYASAN @daisuke-fukuda @hisayan @Yfuruchin