Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine ConfigurationParser #113

Merged
merged 1 commit into from
Nov 24, 2024
Merged

refine ConfigurationParser #113

merged 1 commit into from
Nov 24, 2024

Conversation

XenoAmess
Copy link
Contributor

@XenoAmess XenoAmess commented Sep 24, 2024 •
edited
Loading

  1. performance.
  2. keyword from in package name issue.
  3. add some missing closable resource close

@XenoAmess
refine ConfigurationParser: 1. performance. 2. keyword from in packag…
d813986 
…e name issue. 3. add some missing closable resource close
@XenoAmess
Copy link
Contributor Author

spotless fixed,

mvn --batch-mode --errors --show-version verify javadoc:javadoc passed now

cstamas
cstamas approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@cstamas cstamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Am unsure about formatting, looks odd. Is spotless applied onto plexus? @slawekjaranowski

@slachiewicz slachiewicz merged commit 7572c5f into codehaus-plexus:master Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstamas cstamas cstamas approved these changes

@kwin kwin Awaiting requested review from kwin

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XenoAmess @cstamas @slachiewicz