This repository has been archived by the owner on May 9, 2020. It is now read-only.
Added cookbook support #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution. Would love to cookbook support this make it into a release, is there any plan for an upcoming release that this could be included in? |
|
@coderanger Any update on this? Will be really helpful to have cookbooks in there, we are using pychef on our systems but had to stop using it because of the cookbook feature. |
| self.url = self.__class__.url + '/' + self.name | ||
| # Cookbooks need some special handling, and we default to the | ||
| # latest revision if version goes unspecified. | ||
| if type(self).__name__ == 'Cookbook': |
There was a problem hiding this comment.
This needs to get moved to a classmethod.
Tests were fixed
Replace urllib2 with requests, add option to disable SSL cert verification
|
@coderanger any update on getting this merged in? I see there was some code feedback, then some followup commits, and a failed most-recent commit. What needs to happen next? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like there is already one pending pull request to add cookbook support to pychef. I've taken a slightly different approach by using _latest as the default version to load. I've only performed light testing...
Thanks