This repository has been archived by the owner on May 9, 2020. It is now read-only.
Remove OpenSSL binary dependancy, use pure python RSA instead #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great fix would love to see this merged in! |
freimer
added a commit
to freimer/pychef
that referenced
this pull request
Apr 8, 2016
…ncy, use pure python RSA instead
|
What are the advantages of this approach? |
|
The biggest advantages are:
|
|
I am attempting to maintain an active fork of pychef. I will attempt to pull this into my repo and verify it still works. I will update the MR here once done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of pull requests open trying to fix ctypes for specific platforms.
As requested earlier, this patch gets rid of ctypes and linking in with the OpenSSL library directly and replaces it with a pure native python implementation of RSA - https://pypi.python.org/pypi/rsa
I've tested this on python versions 2.6, 2.7, 3.4 and 3.5.