Merge pull request #51 from coderofstuff/coderofstuff/stax-address-di…

…splay Set the correct length for stax address display
coderofstuff · Oct 9, 2023 · 4762f51 · 4762f51
2 parents 5547e69 + 452a2cd
commit 4762f51
Show file tree

Hide file tree

Showing 17 changed files with 3 additions and 2 deletions.
diff --git a/src/ui/nbgl_display_address.c b/src/ui/nbgl_display_address.c
@@ -46,7 +46,7 @@
 #include "format.h"
 #include "../menu.h"
 
-static char g_address[43];
+static char g_address[ECDSA_ADDRESS_LEN + 6];
 static char g_bip32_path[60];
 
 static nbgl_layoutTagValue_t pairs[1];

diff --git a/src/ui/nbgl_display_transaction.c b/src/ui/nbgl_display_transaction.c
@@ -50,7 +50,7 @@
 // Buffer where the transaction amount string is written
 static char g_amount[30];
 // Buffer where the transaction address string is written
-static char g_address[43];
+static char g_address[ECDSA_ADDRESS_LEN + 6];
 
 static nbgl_layoutTagValue_t pairs[2];
 static nbgl_layoutTagValueList_t pairList;

diff --git a/tests/requirements.txt b/tests/requirements.txt
@@ -5,3 +5,4 @@ Jinja2==3.1.2
 Flask==2.1.2
 pysha3>=1.0.0,<2.0.0
 secp256k1>=0.14.0
+Werkzeug==2.2.2
diff --git a/tests/snapshots/stax/test_get_public_key_confirm_accepted/00001.png b/tests/snapshots/stax/test_get_public_key_confirm_accepted/00001.png
diff --git a/tests/snapshots/stax/test_get_public_key_confirm_accepted/00002.png b/tests/snapshots/stax/test_get_public_key_confirm_accepted/00002.png
diff --git a/tests/snapshots/stax/test_get_public_key_confirm_accepted/00003.png b/tests/snapshots/stax/test_get_public_key_confirm_accepted/00003.png
diff --git a/tests/snapshots/stax/test_get_public_key_confirm_refused/part1/00001.png b/tests/snapshots/stax/test_get_public_key_confirm_refused/part1/00001.png
diff --git a/tests/snapshots/stax/test_sign_tx_max/00001.png b/tests/snapshots/stax/test_sign_tx_max/00001.png
diff --git a/tests/snapshots/stax/test_sign_tx_p2sh/00001.png b/tests/snapshots/stax/test_sign_tx_p2sh/00001.png
diff --git a/tests/snapshots/stax/test_sign_tx_refused/part1/00001.png b/tests/snapshots/stax/test_sign_tx_refused/part1/00001.png
diff --git a/tests/snapshots/stax/test_sign_tx_refused/part2/00001.png b/tests/snapshots/stax/test_sign_tx_refused/part2/00001.png
diff --git a/tests/snapshots/stax/test_sign_tx_simple/00001.png b/tests/snapshots/stax/test_sign_tx_simple/00001.png
diff --git a/tests/snapshots/stax/test_sign_tx_simple_change_idx1/00001.png b/tests/snapshots/stax/test_sign_tx_simple_change_idx1/00001.png
diff --git a/tests/snapshots/stax/test_sign_tx_simple_ecdsa/00001.png b/tests/snapshots/stax/test_sign_tx_simple_ecdsa/00001.png
diff --git a/tests/snapshots/stax/test_sign_tx_simple_sendint/00001.png b/tests/snapshots/stax/test_sign_tx_simple_sendint/00001.png
diff --git a/tests/snapshots/stax/test_sign_tx_simple_sendmaxu64/00001.png b/tests/snapshots/stax/test_sign_tx_simple_sendmaxu64/00001.png
diff --git a/tests/snapshots/stax/test_sign_tx_with_change/00001.png b/tests/snapshots/stax/test_sign_tx_with_change/00001.png