Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow generating the xpub for root node #54

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

coderofstuff
Copy link
Owner

Make the validation of GET_PUBLIC_KEY less strict to allow generation of paths m/44'/111111', m/44'/111111'/<account>, m/44'/111111'/<account>/<type> or m/44'/111111'/<account>/<type>/<index> . Previously it only allowed generation of the path m/44'/111111'/<account>/<type>/<index>

  • This is to allow generation of xpub to allow generating all children addresses with only m/44'/111111'/<account> without the need to interact with the device.

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f4abd89) 91.96% compared to head (0c44680) 91.96%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #54   +/-   ##
=======================================
  Coverage   91.96%   91.96%           
=======================================
  Files           8        8           
  Lines         336      336           
=======================================
  Hits          309      309           
  Misses         27       27           
Flag Coverage Δ
unittests 91.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coderofstuff coderofstuff merged commit 2efa895 into main Oct 15, 2023
33 checks passed
@coderofstuff coderofstuff deleted the resupport-derivation-paths branch October 15, 2023 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants